Skip to content
This repository was archived by the owner on May 28, 2025. It is now read-only.

Commit 84d38c7

Browse files
committed
Move xtask flags around outide the generated section
1 parent e265e3d commit 84d38c7

File tree

2 files changed

+60
-57
lines changed

2 files changed

+60
-57
lines changed

crates/rust-analyzer/src/cli/flags.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -235,6 +235,7 @@ pub struct RunTests {
235235
#[derive(Debug)]
236236
pub struct RustcTests {
237237
pub rustc_repo: PathBuf,
238+
238239
pub filter: Option<String>,
239240
}
240241

xtask/src/flags.rs

Lines changed: 59 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -81,35 +81,6 @@ pub enum XtaskCmd {
8181
Codegen(Codegen),
8282
}
8383

84-
#[derive(Debug)]
85-
pub struct Codegen {
86-
pub check: bool,
87-
pub codegen_type: Option<CodegenType>,
88-
}
89-
90-
#[derive(Debug, Default)]
91-
pub enum CodegenType {
92-
#[default]
93-
All,
94-
Grammar,
95-
AssistsDocTests,
96-
DiagnosticsDocs,
97-
LintDefinitions,
98-
}
99-
100-
impl FromStr for CodegenType {
101-
type Err = String;
102-
fn from_str(s: &str) -> Result<Self, Self::Err> {
103-
match s {
104-
"all" => Ok(Self::All),
105-
"grammar" => Ok(Self::Grammar),
106-
"assists-doc-tests" => Ok(Self::AssistsDocTests),
107-
"diagnostics-docs" => Ok(Self::DiagnosticsDocs),
108-
"lints-definitions" => Ok(Self::LintDefinitions),
109-
_ => Err("Invalid option".to_owned()),
110-
}
111-
}
112-
}
11384
#[derive(Debug)]
11485
pub struct Install {
11586
pub client: bool,
@@ -145,6 +116,65 @@ pub struct PublishReleaseNotes {
145116
pub dry_run: bool,
146117
}
147118

119+
#[derive(Debug)]
120+
pub struct Metrics {
121+
pub measurement_type: Option<MeasurementType>,
122+
}
123+
124+
#[derive(Debug)]
125+
pub struct Bb {
126+
pub suffix: String,
127+
}
128+
129+
#[derive(Debug)]
130+
pub struct Codegen {
131+
pub codegen_type: Option<CodegenType>,
132+
133+
pub check: bool,
134+
}
135+
136+
impl Xtask {
137+
#[allow(dead_code)]
138+
pub fn from_env_or_exit() -> Self {
139+
Self::from_env_or_exit_()
140+
}
141+
142+
#[allow(dead_code)]
143+
pub fn from_env() -> xflags::Result<Self> {
144+
Self::from_env_()
145+
}
146+
147+
#[allow(dead_code)]
148+
pub fn from_vec(args: Vec<std::ffi::OsString>) -> xflags::Result<Self> {
149+
Self::from_vec_(args)
150+
}
151+
}
152+
// generated end
153+
154+
#[derive(Debug, Default)]
155+
pub enum CodegenType {
156+
#[default]
157+
All,
158+
Grammar,
159+
AssistsDocTests,
160+
DiagnosticsDocs,
161+
LintDefinitions,
162+
}
163+
164+
impl FromStr for CodegenType {
165+
type Err = String;
166+
fn from_str(s: &str) -> Result<Self, Self::Err> {
167+
match s {
168+
"all" => Ok(Self::All),
169+
"grammar" => Ok(Self::Grammar),
170+
"assists-doc-tests" => Ok(Self::AssistsDocTests),
171+
"diagnostics-docs" => Ok(Self::DiagnosticsDocs),
172+
"lints-definitions" => Ok(Self::LintDefinitions),
173+
_ => Err("Invalid option".to_owned()),
174+
}
175+
}
176+
}
177+
148178
#[derive(Debug)]
149179
pub enum MeasurementType {
150180
Build,
@@ -185,34 +215,6 @@ impl AsRef<str> for MeasurementType {
185215
}
186216
}
187217

188-
#[derive(Debug)]
189-
pub struct Metrics {
190-
pub measurement_type: Option<MeasurementType>,
191-
}
192-
193-
#[derive(Debug)]
194-
pub struct Bb {
195-
pub suffix: String,
196-
}
197-
198-
impl Xtask {
199-
#[allow(dead_code)]
200-
pub fn from_env_or_exit() -> Self {
201-
Self::from_env_or_exit_()
202-
}
203-
204-
#[allow(dead_code)]
205-
pub fn from_env() -> xflags::Result<Self> {
206-
Self::from_env_()
207-
}
208-
209-
#[allow(dead_code)]
210-
pub fn from_vec(args: Vec<std::ffi::OsString>) -> xflags::Result<Self> {
211-
Self::from_vec_(args)
212-
}
213-
}
214-
// generated end
215-
216218
impl Install {
217219
pub(crate) fn server(&self) -> Option<ServerOpt> {
218220
if self.client && !self.server {

0 commit comments

Comments
 (0)