Implements TryFrom for Deque from array #524
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hicklin
changed the title
hicklin
changed the title
newAM
requested changes
Jan 14, 2025
petekubiak
approved these changes
Jan 24, 2025
hicklin
force-pushed
the
impl_try_from_for_deque
branch
from
aa6f7a2 to
e922e5a
Compare
newAM
requested changes
Mar 9, 2025
newAM
changed the title
Co-authored-by: Alex Martens <alex@thinglab.org>
hicklin
force-pushed
the
impl_try_from_for_deque
branch
from
9c6db76 to
8907839
Compare
reitermarkus
reviewed
Apr 6, 2025
.gitignore
Outdated
| @@ -2,3 +2,4 @@ | |||
| .#* | |||
| Cargo.lock | |||
| target/ | |||
| .idea | |||
reitermarkus
reviewed
Apr 6, 2025
src/deque.rs
Outdated
| /// ``` | ||
| /// use heapless::Deque; | ||
| /// | ||
| /// let deq1 = Deque::<u8, 4>::try_from([1, 2, 3, 4]).unwrap(); |
There was a problem hiding this comment.
Might make more sense to use different NS/ND in the example.
There was a problem hiding this comment.
Is this what you mean? 2dfeabe
reitermarkus
reviewed
Apr 6, 2025
src/deque.rs
Outdated
| /// | ||
| /// assert_eq!(deq1, deq2); | ||
| /// ``` | ||
| type Error = (); |
There was a problem hiding this comment.
Addressed here aca4aa9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522.
Ideally, this PR is updated after PR #521 is merged to simplify the tests.
This PR implements the
TryFromtrait for creating aDequefrom a slice.Note the use of
unsafefor copying all bytes from the slice to theDequebuffer after ensuring that theDequebuffer has enough space.Also note the use of
ManuallyDropto ensure that any heap memory referred to by the element contents is not dropped at the end of this method since the elements in theDequebuffer will be pointing to it.