Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add std Entry methods to indexmap Entry #468

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

leonzchang
Copy link
Contributor

Description

It would be nice to have some methods for Entry like std HashMap Entry so that developer can using chained method calls.

reitermarkus
reitermarkus previously approved these changes May 26, 2024
@reitermarkus
Copy link
Member

@leonzchang, can you please rebase this?

@leonzchang
Copy link
Contributor Author

@leonzchang, can you please rebase this?

Sure~

@vpochapuis
Copy link

Hello~
Any update on this PR? the implemented features add quite some convenience to the crate~

Dirbaio
Dirbaio previously approved these changes Jun 30, 2024
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

(rebased again)

@Dirbaio Dirbaio enabled auto-merge June 30, 2024 23:11
@Dirbaio Dirbaio added this pull request to the merge queue Jun 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jun 30, 2024
@Dirbaio Dirbaio added this pull request to the merge queue Jun 30, 2024
Merged via the queue into rust-embedded:main with commit 9abec11 Jun 30, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants