Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String: add StringView, similar to VecView #452

Closed
wants to merge 11 commits into from

Conversation

sosthene-nitrokey
Copy link
Contributor

Follow up of #425

This time we need a dedicated sealed module for StringInner, because of the pub mod string in lib.rs. Maybe VecInner should have the same treatment, in case some time in the future the vec module is made public.

@reitermarkus
Copy link
Member

Please use a macro to implement the traits, as I did in #451.

@sosthene-nitrokey
Copy link
Contributor Author

Done. And I added some inline hints similarly to #451

src/string.rs Outdated Show resolved Hide resolved
src/string.rs Outdated Show resolved Hide resolved
src/string.rs Outdated Show resolved Hide resolved
src/string.rs Outdated Show resolved Hide resolved
src/string.rs Outdated Show resolved Hide resolved
src/string.rs Outdated Show resolved Hide resolved
src/string.rs Outdated Show resolved Hide resolved
src/string.rs Outdated Show resolved Hide resolved
src/string.rs Outdated Show resolved Hide resolved
@Dirbaio
Copy link
Member

Dirbaio commented Jun 30, 2024

closing in favor of #487

@Dirbaio Dirbaio closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants