Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is ptr() function on RegisterBlock's actually deprecated or not? #370

Closed
TDHolmes opened this issue Dec 15, 2021 · 3 comments
Closed

is ptr() function on RegisterBlock's actually deprecated or not? #370

TDHolmes opened this issue Dec 15, 2021 · 3 comments

Comments

@TDHolmes
Copy link
Contributor

I see that the ptr() function to get the pointer to the register block has the comment "to be deprecated in 0.7", but it's already 0.7 and it isn't deprecated... was this just missed or is it no longer the plan?
@TDHolmes TDHolmes mentioned this issue Dec 15, 2021
Open
@TDHolmes
Copy link
Contributor Author

TDHolmes commented Jan 6, 2022

some context: #235 (comment) / #235

@adamgreig
Copy link
Member

Oops, I think this was simply missed for 0.7. We can deprecate it in the existing 0.7 series though, and remove it for 0.8.

TDHolmes added a commit to TDHolmes/cortex-m that referenced this issue Jan 6, 2022
@TDHolmes
remove the ptr() function in favor of the PTR constant
7f2cc1a 
Per rust-embedded#370/rust-embedded#235, the const fn ptr() was supposed to be deprecated and
subsequently removed. This PR removes it for the master branch tracking
the 0.8 release
@TDHolmes TDHolmes mentioned this issue Jan 6, 2022
Merged
TDHolmes added a commit to TDHolmes/cortex-m that referenced this issue Jan 6, 2022
@TDHolmes
remove the ptr() function in favor of the PTR constant
9e098a4 
Per rust-embedded#370/rust-embedded#235, the const fn ptr() was supposed to be deprecated and
subsequently removed. This PR removes it for the master branch tracking
the 0.8 release
@TDHolmes TDHolmes mentioned this issue Jan 6, 2022
Merged
bors bot added a commit that referenced this issue Jan 10, 2022
@bors @TDHolmes
Merge #386
b581ec7 
386: deprecate `ptr()` function for the v0.7.x series r=adamgreig a=TDHolmes

Deprecating `ptr()` in `v0.7.x` series per #370

Co-authored-by: Tyler Holmes <tyler@holmesengineering.com>
bors bot added a commit that referenced this issue Jan 10, 2022
@bors @TDHolmes
Merge #385
92552c7 
385: remove the ptr() function in favor of the PTR constant r=adamgreig a=TDHolmes

Per #370/#235, the const fn ptr() was supposed to be deprecated and subsequently removed. This PR removes it for the master branch tracking the 0.8 release

Co-authored-by: Tyler Holmes <tyler@holmesengineering.com>
@reitermarkus
Copy link
Member

I think this can be closed, right?

@TDHolmes TDHolmes closed this as completed Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adamgreig @reitermarkus @TDHolmes