Add LFN support when iterating directories #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Long File Names carry this checksum of their matching Short File Name.
Used to buffer Long File Names. Designed to be fed 16-bit UCS-2 chunks in reverse, like you find in a directory.
Scoops up bits of LFN into the given LFN buffer and if it all looks OK, passes it to the user-supplied closure as a &str.
Removes a bunch of const generics from the API.
|
ugh, dealing with the fact that one unicode character might become two UTF-16 code units, and those two code units could be split across two directory entries, was a nightmare. But I think this works. |
eldruin
reviewed
Oct 28, 2024
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now optionally see the long file names when doing directory listings. To do so you must pass an
LfnBufferof your chosen size to the newiterate_dir_lfnmethods.