Always closing (and more) #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpallant
previously requested changes
Mar 28, 2024
thejpster
requested changes
Mar 29, 2024
|
Sorry, spotted a few more things on this pass. And would you mind squashing the branch - we've got some commits that are now redundant. |
peterkrull
force-pushed
the
always-closing
branch
from
e9d0fbf
to
86c20e0
Compare
thejpster
approved these changes
Mar 30, 2024
|
Looks good to me - thank you! |
Merged
via the queue into
rust-embedded-community:develop
with commit Mar 30, 2024
710bd34
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answering my own issue #122 with this one.
When calling
VolumeManager::close_file(..)one would expect the file index to actually be removed from the volume manager, even if flushing the data to the card fails. This is currently not the case due to any errors during flushing short-circuiting the error. This PR addresses that.I have also taken some the liberties in turning some for-loop searches into iterators, and removed panicking behavior from the
impl Drops on volumes, directories and files.