Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIR's Slice should be SliceRef or BorrowedSlice #293

Open
robertbastian opened this issue Dec 6, 2022 · 1 comment
Open

HIR's Slice should be SliceRef or BorrowedSlice #293

robertbastian opened this issue Dec 6, 2022 · 1 comment
Labels
help wanted Extra attention is needed techdebt Internal issue with minimal external impact

Comments

@robertbastian
Copy link
Collaborator

"Slice" is the unsized datatype [T], which we don't support.

In the future we want an OwnedSlice (a.k.a. Box<[T]>), so we should be clear about what type of slice this is.

@Manishearth
Copy link
Contributor

IME in usual parlance "slice" refers to the reference types, with "unsized slice" and "box slice" being used for the others. The unsized datatype is technically called slice but it's rather rare so nobody really does.

That said I'm fine with SliceRef.

@Manishearth Manishearth added help wanted Extra attention is needed techdebt Internal issue with minimal external impact labels Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed techdebt Internal issue with minimal external impact
Projects
None yet
Development

No branches or pull requests

2 participants