Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline docs in C headers #101

Open
sffc opened this issue Nov 10, 2021 · 1 comment
Open

Add inline docs in C headers #101

sffc opened this issue Nov 10, 2021 · 1 comment
Labels
B-C C backends enhancement New feature or request good first issue Good for newcomers

Comments

@sffc
Copy link
Contributor

sffc commented Nov 10, 2021

From @dminor in unicode-org/icu4x#1269 (comment):

Is it intentional for the C++ headers to include comments, but not the C headers? It makes sense that the copies of the C headers in ffi/diplomat/cpp are just an implementation detail of the C++ headers, but the same argument doesn't seem to hold for ffi/diplomat/c.

Note: @gregtatum added C++ docs generation in #85. The primary documentation is intended to be the *.rst files, but perhaps we should put the docs into the *.h files as well.

@sffc sffc added enhancement New feature or request good first issue Good for newcomers labels Nov 10, 2021
@gregtatum
Copy link
Collaborator

Yeah, this would be really nice for in-editor hints. There was no particularly reason for not doing C headers, other than it was more work that just doing C++ headers.

@Manishearth Manishearth added B-C-AST B-C C backends and removed B-C-AST labels Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B-C C backends enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants