Target::Pipe doesn't work

[oxalica]

In #204, we introduce Target::Pipe to redirect log messages into custom writer. And it's included in 0.8.4 now.
But when I try the example in that PR, it doesn't print the message from pipe at all, and not even call WriteAdapter::write. The log::error message just go straight to stderr.
How to make it catch all log message into my custom writer object?

[TilCreator]

I also just noticed that. I read the code (of #204), but never actually tested it... I kind of just assumed that it would work, because it didn't change much of my code (#195).
I'm currently looking into it (I also already found at least one error, but it's just in the documentation)

[jplatte]

Thanks for looking into it, and sorry for breaking things.

[TilCreator]

I have found the error in fmt::writer::termcolor::extern_impl::BufferWriter
The change removed the target_pipe which is good, less convoluted.
In fmt::writer::termcolor::extern_impl::BufferWriter::print the if for the pipe was removed and integrated into the match a few lines down, but that only works if there is a test_target, because BufferWriter::inner (a termcolor::BufferWriter) is unable to write to the pipe.

[TilCreator]

A easy solution would be to change BufferWriter::pipe to always set test_target, but that feels quite hacky... (it also removes color, so not really a solution)

[jplatte]

I think we should no longer unconditionally hold that BufferWriter, it doesn't make sense for the pipe target.

it also removes color, so not really a solution

Removes color in general, or when using a Pipe writer? For the latter, I would expect colorization to be turned off. You could print the escape sequences, but that's unix-specific and would lead to very ugly output if it's not expected on the "other side" of the pipe.

[TilCreator]

I explicitly enabled colors, else the default for pipes would be to disable color.

[TilCreator]

I will try the idea without the BufferWriter

[TilCreator]

I think we should no longer unconditionally hold that BufferWriter, it doesn't make sense for the pipe target.

Something like this?
TilCreator@fbeebcf

[tubzby]

Same problem here.

[Polochon-street]

Can report having the same problem - that would be a really awesome addition if that worked though 😄

[TilCreator]

Ups, it has been a few days...
Sry, I opened #211 which fixes this (but it's not perfect).

[mainrs]

I do also think that colors disabled makes more sense for pipes (by default). We could think about adding some kind of way to enable them back again.

[TilCreator]

It is already disabled by default for pipes, the example just enables them to show that it's possible.