clippy: eliminate a bunch of redundant into_iter calls

Author: apoelstra

src/descriptor/key.rs

@@ -943,7 +943,7 @@ impl<K: InnerXKey> DescriptorXKey<K> {
             Some((fingerprint, ref path)) => (
                 fingerprint,
                 path.into_iter()
-                    .chain(self.derivation_path.into_iter())
+                    .chain(&self.derivation_path)
                     .collect(),
             ),
             None => (

src/plan.rs

@@ -383,7 +383,7 @@ impl Plan {
                     .entry(pk)
                     .and_modify(|(leaf_hashes, _)| {
                         if let Some(lh) = leaf_hash {
-                            if leaf_hashes.iter().find(|&&i| i == lh).is_none() {
+                            if leaf_hashes.iter().all(|&i| i != lh) {
                                 leaf_hashes.push(lh);
                             }
                         }
@@ -661,15 +661,15 @@ pub trait IntoAssets {
 }
 
 impl IntoAssets for KeyMap {
-    fn into_assets(self) -> Assets { Assets::from_iter(self.into_iter().map(|(k, _)| k)) }
+    fn into_assets(self) -> Assets { Assets::from_iter(self.into_keys()) }
 }
 
 impl IntoAssets for DescriptorPublicKey {
     fn into_assets(self) -> Assets { vec![self].into_assets() }
 }
 
 impl IntoAssets for Vec<DescriptorPublicKey> {
-    fn into_assets(self) -> Assets { Assets::from_iter(self.into_iter()) }
+    fn into_assets(self) -> Assets { Assets::from_iter(self) }
 }
 
 impl IntoAssets for sha256::Hash {
@@ -723,14 +723,14 @@ impl Assets {
     }
 
     fn append(&mut self, b: Self) {
-        self.keys.extend(b.keys.into_iter());
-        self.sha256_preimages.extend(b.sha256_preimages.into_iter());
+        self.keys.extend(b.keys);
+        self.sha256_preimages.extend(b.sha256_preimages);
         self.hash256_preimages
-            .extend(b.hash256_preimages.into_iter());
+            .extend(b.hash256_preimages);
         self.ripemd160_preimages
-            .extend(b.ripemd160_preimages.into_iter());
+            .extend(b.ripemd160_preimages);
         self.hash160_preimages
-            .extend(b.hash160_preimages.into_iter());
+            .extend(b.hash160_preimages);
 
         self.relative_timelock = b.relative_timelock.or(self.relative_timelock);
         self.absolute_timelock = b.absolute_timelock.or(self.absolute_timelock);