improve example: take hex-encoded seed instead of WIF in bip32 example #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoelstra
previously approved these changes
Jan 9, 2022
Member
apoelstra
left a comment
apoelstra
left a comment
There was a problem hiding this comment.
ACK 1bd54ab82cca8e39ab86eaa02ee6b6087a8f3493
This looks perfect, thanks!
kafaichoi
force-pushed
the
fix-bip32-misleading-example
branch
from
1bd54ab to
bb70820
Compare
Contributor
Author
Thanks. just rebased master and fix test in |
RCasatta
approved these changes
Jan 10, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my understanding of what we want to fix the confusing bip32 example. Apologize in advance if I misunderstand it.
Closes #748