Use unsafe APIs to optimize HexDisplay::to_hex_from
#1848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unparalleled-Calvin
changed the title
HexDisplayDisplayto_hex_fromHexDisplayDisplayto_hex_from
Unparalleled-Calvin
changed the title
HexDisplayDisplayto_hex_fromHexDisplay::to_hex_from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! This PR uses unsafe APIs including
ptr::writeandString::from_utf8_uncheckedto boost performance ofnom::HexDisplay::to_hex_from. Issue#1847 explains its safety and effectiveness.The test and benchmark results demonstrate a 30% performance improvement for 36-byte data payloads while maintaining identical functionality to the existing implementation.
Btw, I am happy to provide the test and benchmark code if they are needed.