Skip to content

Commit fae19b8

Browse files
saschahauervireshk
authored andcommitted
cpufreq: imx6q: Fix clock enable balance
For changing the cpu frequency the i.MX6q has to be switched to some intermediate clock during the PLL reprogramming. The driver tries to be clever to keep the enable count correct but gets it wrong. If the cpufreq is increased it calls clk_disable_unprepare twice on pll2_pfd2_396m. This puts all other devices which get their clock from pll2_pfd2_396m into a nonworking state. Fix this by removing the clk enabling/disabling altogether since the clk core will do this automatically during a reparent. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
1 parent b192b91 commit fae19b8

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

drivers/cpufreq/imx6q-cpufreq.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -117,28 +117,11 @@ static int imx6q_set_target(struct cpufreq_policy *policy,
117117
* - Reprogram pll1_sys_clk and reparent pll1_sw_clk back to it
118118
* - Disable pll2_pfd2_396m_clk
119119
*/
120-
clk_prepare_enable(pll2_pfd2_396m_clk);
121120
clk_set_parent(step_clk, pll2_pfd2_396m_clk);
122121
clk_set_parent(pll1_sw_clk, step_clk);
123122
if (freq_hz > clk_get_rate(pll2_pfd2_396m_clk)) {
124123
clk_set_rate(pll1_sys_clk, freqs.new * 1000);
125-
/*
126-
* If we are leaving 396 MHz set-point, we need to enable
127-
* pll1_sys_clk and disable pll2_pfd2_396m_clk to keep
128-
* their use count correct.
129-
*/
130-
if (freqs.old * 1000 <= clk_get_rate(pll2_pfd2_396m_clk)) {
131-
clk_prepare_enable(pll1_sys_clk);
132-
clk_disable_unprepare(pll2_pfd2_396m_clk);
133-
}
134124
clk_set_parent(pll1_sw_clk, pll1_sys_clk);
135-
clk_disable_unprepare(pll2_pfd2_396m_clk);
136-
} else {
137-
/*
138-
* Disable pll1_sys_clk if pll2_pfd2_396m_clk is sufficient
139-
* to provide the frequency.
140-
*/
141-
clk_disable_unprepare(pll1_sys_clk);
142125
}
143126

144127
/* Ensure the arm clock divider is what we expect */

0 commit comments

Comments
 (0)