Skip to content

Commit 4569164

Browse files
committed
Update readme file
1 parent 612d52e commit 4569164

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

.github/workflows/app-engine-deploy.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ on:
77
branches:
88
- main
99

10-
env:
11-
PROJECT_ID: '${{ secrets.PROJECT_ID }}'
12-
1310
jobs:
1411
deploy:
1512
runs-on: 'ubuntu-latest'

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
## 🧑‍💻 Local Setup
1818
- Enable App Engine, App Engine Admin API, Cloud Build
1919
- Create a service account(with permission App Engine Admin, Cloud Build Editor, Storage Admin, Service Account User), create a key, download the key in local
20-
- In Google Cloud console select App Engine and create application in any region(this is one time activity and has to manually)
20+
- In Google Cloud console select App Engine and create application in any region(this is one time activity and has to do manually)
2121
- Add GitHub Secrets to your repo: Repo → Settings → Secrets and variables → Actions → New repository secret as GCP_SA_KEY = contents of key.json (JSON string)
2222
- Create a simple node.js app with app.yaml
2323
- Create a .github/workflows/deploy.yml file in root of your node app

0 commit comments

Comments
 (0)