Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test with high branching factor #162

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

lucasmt
Copy link
Contributor

@lucasmt lucasmt commented Nov 8, 2023

Adds a test with a high branching factor in order to test new features like node merging and branch parallelization.

The test splits into 8 branches in total (and this can be increased by increasing the length of the proof array). It takes 1h to run on my machine.

@lucasmt lucasmt marked this pull request as ready for review November 8, 2023 17:01
@ehildenb
Copy link
Member

ehildenb commented Nov 8, 2023

We should add an actual test to the testing harness that merges the nodes and makes assertions about them. For example, it should be added to this test harness that the node merging is happening correctly: https://github.com/runtimeverification/kontrol/blob/master/src/tests/integration/test_foundry_prove.py#L236

@lucasmt
Copy link
Contributor Author

lucasmt commented Nov 20, 2023

@ehildenb Currently I don't think it's feasible to apply node merging to this example, because of this issue: #194.

@palinatolmach
Copy link
Collaborator

@nwatson22 brought up another challenge in adding this example to our test suite: the merge node functionality requires the user to accurately specify nodes to be merged, and it might be nontrivial to identify and add such nodes to the kcfg in this example. This should be partially addressed in #163, but it requires additional changes and is not being worked on at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants