Remove lemma 6 from keccak.md
#1077
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes lemma 6 from
keccak.md
. Unlike other keccak lemmas, which are technically unsound but safe under keccak's cryptographic properties, this lemma can cause tests to miss certain valid edge cases and pass when they should fail. This PR also introduces a new testSlotsDisjointTest.testReceiver
as an example (found by @lisandrasilva). With lemma 6, the test passes, but it should fail now that the lemma has been removed.If a situation arises that requires this lemma, there are a few alternatives:
lemmas.k
file in the project, but make extra sure that there aren't edge cases that might be missed like in the provided example. This decision must be made intentionally in a project-by-project basis, rather than having this lemma upstreamed into Kontrol where it will be included by default, possibly without the user's knowledge.