cannot use --statistics with multiple properties

[owolabileg]

This probably has to do with the fileCombiner.

To reproduce, run javamop -agent -s -usedb or

cd examples/agent/many
javamop -agent -s rvm

You will get errors like this:

/home/owolabi/projects/javamop/examples/agent/many/out/JavaMOPAgent_1MonitorAspect.aj:4239 [error] UnsafeMapIteratorMonitorAspect cannot be resolved to a variable
UnsafeMapIteratorMonitorAspect.UnsafeMapIterator_TerminatedMonitor_num++;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

With a single property, it works:

cd examples/agent/HasNext
javamop -agent -s rvm

I'll assign this to @seriousamlqz

[grosu]

Is this a javamop of an RV-Monitor problem?

Grigore

---

From: Owolabi Legunsen [notifications@github.com]
Sent: Tuesday, October 28, 2014 6:45 PM
To: runtimeverification/javamop
Subject: [javamop] cannot use --statistics with multiple properties (#160)

This probably has to do with the fileCombiner.

To reproduce, run javamop -agent -s -usedb or

cd examples/agent/many
javamop -agent -s rvm

You will get errors like this:

/home/owolabi/projects/javamop/examples/agent/many/out/JavaMOPAgent_1MonitorAspect.aj:4239 [error] UnsafeMapIteratorMonitorAspect cannot be resolved to a variable
UnsafeMapIteratorMonitorAspect.UnsafeMapIterator_TerminatedMonitor_num++;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

With a single property, it works:

cd examples/agent/HasNext
javamop -agent -s rvm

I'll assign this to @seriousamlqzhttps://github.com/seriousamlqz

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/160.

[seriousamlqz]

I am not sure right now, will investigate later.

On Tuesday, October 28, 2014, Grigore Rosu notifications@github.com wrote:

Is this a javamop of an RV-Monitor problem?

Grigore

---

From: Owolabi Legunsen [notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');]
Sent: Tuesday, October 28, 2014 6:45 PM
To: runtimeverification/javamop
Subject: [javamop] cannot use --statistics with multiple properties (#160)

This probably has to do with the fileCombiner.

To reproduce, run javamop -agent -s -usedb or

cd examples/agent/many
javamop -agent -s rvm

You will get errors like this:

/home/owolabi/projects/javamop/examples/agent/many/out/JavaMOPAgent_1MonitorAspect.aj:4239
[error] UnsafeMapIteratorMonitorAspect cannot be resolved to a variable
UnsafeMapIteratorMonitorAspect.UnsafeMapIterator_TerminatedMonitor_num++;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

With a single property, it works:

cd examples/agent/HasNext
javamop -agent -s rvm

I'll assign this to @seriousamlqzhttps://github.com/seriousamlqz

—
Reply to this email directly or view it on GitHub<
https://github.com/runtimeverification/javamop/issues/160>.

—
Reply to this email directly or view it on GitHub
#160 (comment)
.

Qingzhou Luo
http://mir.cs.illinois.edu/~qluo2/

Department of Computer Science
University of Illinois, Urbana Champaign

[seriousamlqz]

Owolabi, could you please first write a failing IT test(could be put in the
same test class) before I fix that? I can then check out your branch.
Thanks!

On Tuesday, October 28, 2014, Owolabi Legunsen notifications@github.com
wrote:

This probably has to do with the fileCombiner.

To reproduce, run javamop -agent -s -usedb or

cd examples/agent/many
javamop -agent -s rvm

You will get errors like this:

/home/owolabi/projects/javamop/examples/agent/many/out/JavaMOPAgent_1MonitorAspect.aj:4239 [error] UnsafeMapIteratorMonitorAspect cannot be resolved to a variable
UnsafeMapIteratorMonitorAspect.UnsafeMapIterator_TerminatedMonitor_num++;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

With a single property, it works:

cd examples/agent/HasNext
javamop -agent -s rvm

I'll assign this to @seriousamlqz https://github.com/seriousamlqz

—
Reply to this email directly or view it on GitHub
#160.

Qingzhou Luo
http://mir.cs.illinois.edu/~qluo2/

Department of Computer Science
University of Illinois, Urbana Champaign

[owolabileg]

I made such a branch with a test here. I did not know how to make the test fail, but I put the expected and the actual output in that branch.

Thanks!

[seriousamlqz]

Grigore,

I would again say the problem is in RV-Monitor. To solve the problem
completely, we should move all the code generated by -s from aspect to
Monitor class.

Right now all the counters for statistics are kept in the aspect rather
than the Monitor class. But -s is a valid argument for RV-Monitor, so if we
do rv-monitor -s a.rvm, it will generate code which call
MonitorAspect.counter++.

This is wrong because RV-Monitor shouldn't be aware of aspect at all. I can
reply in my early bug report for RV-Monitor about this.

Qingzhou

On Tue, Oct 28, 2014 at 6:47 PM, Grigore Rosu notifications@github.com
wrote:

Is this a javamop of an RV-Monitor problem?

Grigore

---

From: Owolabi Legunsen [notifications@github.com]
Sent: Tuesday, October 28, 2014 6:45 PM
To: runtimeverification/javamop
Subject: [javamop] cannot use --statistics with multiple properties (#160)

This probably has to do with the fileCombiner.

To reproduce, run javamop -agent -s -usedb or

cd examples/agent/many
javamop -agent -s rvm

You will get errors like this:

/home/owolabi/projects/javamop/examples/agent/many/out/JavaMOPAgent_1MonitorAspect.aj:4239
[error] UnsafeMapIteratorMonitorAspect cannot be resolved to a variable
UnsafeMapIteratorMonitorAspect.UnsafeMapIterator_TerminatedMonitor_num++;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

With a single property, it works:

cd examples/agent/HasNext
javamop -agent -s rvm

I'll assign this to @seriousamlqzhttps://github.com/seriousamlqz

—
Reply to this email directly or view it on GitHub<
https://github.com/runtimeverification/javamop/issues/160>.

—
Reply to this email directly or view it on GitHub
#160 (comment)
.

Qingzhou Luo
http://mir.cs.illinois.edu/~qluo2/

Department of Computer Science
University of Illinois, Urbana Champaign

[grosu]

Make it into an issue on github, please, or more issues! Phil will check those issues carefully, but I'm not sure if he checks the javamop ones that carefully.

Grigore

---

From: seriousamlqz [notifications@github.com]
Sent: Tuesday, October 28, 2014 9:17 PM
To: runtimeverification/javamop
Cc: Rosu, Grigore
Subject: Re: [javamop] cannot use --statistics with multiple properties (#160)

Grigore,

I would again say the problem is in RV-Monitor. To solve the problem
completely, we should move all the code generated by -s from aspect to
Monitor class.

Right now all the counters for statistics are kept in the aspect rather
than the Monitor class. But -s is a valid argument for RV-Monitor, so if we
do rv-monitor -s a.rvm, it will generate code which call
MonitorAspect.counter++.

This is wrong because RV-Monitor shouldn't be aware of aspect at all. I can
reply in my early bug report for RV-Monitor about this.

Qingzhou

On Tue, Oct 28, 2014 at 6:47 PM, Grigore Rosu notifications@github.com
wrote:

Is this a javamop of an RV-Monitor problem?

Grigore

---

From: Owolabi Legunsen [notifications@github.com]
Sent: Tuesday, October 28, 2014 6:45 PM
To: runtimeverification/javamop
Subject: [javamop] cannot use --statistics with multiple properties (#160)

This probably has to do with the fileCombiner.

To reproduce, run javamop -agent -s -usedb or

cd examples/agent/many
javamop -agent -s rvm

You will get errors like this:

/home/owolabi/projects/javamop/examples/agent/many/out/JavaMOPAgent_1MonitorAspect.aj:4239
[error] UnsafeMapIteratorMonitorAspect cannot be resolved to a variable
UnsafeMapIteratorMonitorAspect.UnsafeMapIterator_TerminatedMonitor_num++;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

With a single property, it works:

cd examples/agent/HasNext
javamop -agent -s rvm

I'll assign this to @seriousamlqzhttps://github.com/seriousamlqz

—
Reply to this email directly or view it on GitHub<
https://github.com/runtimeverification/javamop/issues/160>.

—
Reply to this email directly or view it on GitHub
#160 (comment)
.

Qingzhou Luo
http://mir.cs.illinois.edu/~qluo2/

Department of Computer Science
University of Illinois, Urbana Champaign

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/160#issuecomment-60863906.

[seriousamlqz]

Owolabi,

Which part you found it hard of making the test fail? You can just execute
the same command in your bug report and check whether that command succeed
or not. With the bug it will throw an exception so it won't succeed, so the
test will fail.

You should read the code in TestHelper.java to have a better understanding
of those integration tests. For example, all the different parameters in
testCommand.

Thanks,

Qingzhou

On Tuesday, October 28, 2014, Grigore Rosu notifications@github.com wrote:

Make it into an issue on github, please, or more issues! Phil will check
those issues carefully, but I'm not sure if he checks the javamop ones that
carefully.

Grigore

---

From: seriousamlqz [notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');]
Sent: Tuesday, October 28, 2014 9:17 PM
To: runtimeverification/javamop
Cc: Rosu, Grigore
Subject: Re: [javamop] cannot use --statistics with multiple properties
(#160)

Grigore,

I would again say the problem is in RV-Monitor. To solve the problem
completely, we should move all the code generated by -s from aspect to
Monitor class.

Right now all the counters for statistics are kept in the aspect rather
than the Monitor class. But -s is a valid argument for RV-Monitor, so if
we
do rv-monitor -s a.rvm, it will generate code which call
MonitorAspect.counter++.

This is wrong because RV-Monitor shouldn't be aware of aspect at all. I
can
reply in my early bug report for RV-Monitor about this.

Qingzhou

On Tue, Oct 28, 2014 at 6:47 PM, Grigore Rosu <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');>
wrote:

Is this a javamop of an RV-Monitor problem?

Grigore

---

From: Owolabi Legunsen [notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');]
Sent: Tuesday, October 28, 2014 6:45 PM
To: runtimeverification/javamop
Subject: [javamop] cannot use --statistics with multiple properties
(#160)

This probably has to do with the fileCombiner.

To reproduce, run javamop -agent -s -usedb or

cd examples/agent/many
javamop -agent -s rvm

You will get errors like this:

/home/owolabi/projects/javamop/examples/agent/many/out/JavaMOPAgent_1MonitorAspect.aj:4239

[error] UnsafeMapIteratorMonitorAspect cannot be resolved to a variable

UnsafeMapIteratorMonitorAspect.UnsafeMapIterator_TerminatedMonitor_num++;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

With a single property, it works:

cd examples/agent/HasNext
javamop -agent -s rvm

I'll assign this to @seriousamlqzhttps://github.com/seriousamlqz

—
Reply to this email directly or view it on GitHub<
https://github.com/runtimeverification/javamop/issues/160>.

—
Reply to this email directly or view it on GitHub
<
https://github.com/runtimeverification/javamop/issues/160#issuecomment-60851841>

.

Qingzhou Luo
http://mir.cs.illinois.edu/~qluo2/

Department of Computer Science
University of Illinois, Urbana Champaign

—
Reply to this email directly or view it on GitHub<
https://github.com/runtimeverification/javamop/issues/160#issuecomment-60863906>.

—
Reply to this email directly or view it on GitHub
#160 (comment)
.

Qingzhou Luo
http://mir.cs.illinois.edu/~qluo2/

Department of Computer Science
University of Illinois, Urbana Champaign

[seriousamlqz]

Hi,

I'd like to add you to my professional network on LinkedIn.

• Qingzhou

Accept: https://www.linkedin.com/blink?simpleRedirect=0ScjgMd3cTcPATcP8MejsRdPARfkh9rCZFt65QqnpKqipvmCIVrAFlq3RVpkJApn9xq7cCt7dBtmtvpnhFtCVFfmJB9C5QoORBt6BSrCAJt7dBtmsJr6RBfmtKqmJzon9Q9ClQqnpKimtBkClOs3Rx9CIQbnhLp39IqjpFbmkNpjwRqzRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I5975790255557611521_500&markAsRead=

You received an invitation to connect. LinkedIn will use your email address to make suggestions to our members in features like People You May Know. Unsubscribe here: https://www.linkedin.com/blink?simpleRedirect=qPgJt6ZAcCNFdCAJpj5Be3lGfmhFpiphdD5cmm4Ur7lCrCcOsOR3jjdLm71qmzhJj2QMiAl7rSN4l3hgdmBCjTdlr4xMbjBAh6wNr7FGhP5kkDd1c6JOl3sPdCFLs5BTiQZ8tDENp5B2jAhKen9ojSR8kmoOoSMOsSxximMVpnBHp4pUjCJ4uz1ps3tVh6Blenlqm7cNsAJ8uDlFmAVSgPgUinhMhzlRlk51gmtfdnBQlAhziShzi551fmhFrSMCt7dBtmtvpnhFtCVFfmJB9B4ScSh5hSxmhD9JhB51fmVBqSZkp6BJ9CVRr3RQ9CIQbnhLp39IqjpFbmkNpjwRqzRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&amp;msgID=I5975790255557611521_500&amp;markAsRead= Learn why we included this at the following link: https://www.linkedin.com/blink?simpleRedirect=e3wTd3RAimlIoSBQsC4Ct7dBtmtvpnhFtCVFfmJB9CNOlmlzqnpOpldOpmRLt7dRoPRx9CIQbnhLp39IqjpFbmkNpjwRqzRBfP9SbSkLrmZzbCVFp6lHrCBIbDtTtOYLeDdMt7hE&msgID=I5975790255557611521_500&markAsRead=
© 2014, LinkedIn Corporation. 2029 Stierlin Ct. Mountain View, CA 94043, USA