Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement structural checkers for proofs #1994

Open
tothtamas28 opened this issue Aug 4, 2023 · 2 comments
Open

Implement structural checkers for proofs #1994

tothtamas28 opened this issue Aug 4, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@tothtamas28
Copy link
Contributor

tothtamas28 commented Aug 4, 2023

This would enable us to verify foundry_prove test results structurally, as opposed to comparing foundry_show output to an expected string, which is very brittle.

@ehildenb
Copy link
Member

ehildenb commented Aug 4, 2023

What we really want to test is something like:

  • Same graph structure overall.
  • Same depth of each basic block.
  • Same branching conditions.
  • Same end conditions.
  • Roughly same configuration each state.

Comparing the string output roughly approximates that, but doing it structurally would be better. Maybe we store the actual KCFGs and have an intentional way of diffing them (or the APRProof)?

@tothtamas28 tothtamas28 changed the title Implement proof checkers Implement structural checkers for proofs Aug 4, 2023
@tothtamas28
Copy link
Contributor Author

Renamed the PR and edited the description to better reflect this goal.

@yale-vinson yale-vinson added the enhancement New feature or request label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants