Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

foundry-list.check Makefile rule erases tests/foundry/out/ag_proofs, which it relies on #1741

Open
nwatson22 opened this issue Apr 19, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@nwatson22
Copy link
Member

The Makefile rule tests/foundry/foundry-list.check has tests/foundry/out as an indirect dependency, so when I make it with -B, it erases the tests/foundry/out/ag_proofs directory, and this makes it easy to waste a lot of time by running this rule by mistake because in order to regenerate the foundry-list test file all the proofs in the test-foundry-prove need to be re-run.

Ideally we'd have some way for make to be able to tell if test-foundry-prove needs to be rerun and make this a dependency of tests/foundry/foundry-list.out, but if that's not possible, I think we should move everything currently in tests/foundry/out into its own directory and have tests/foundry/out be only for the generated JSON files.

@nwatson22 nwatson22 added the enhancement New feature or request label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant