test: Add e2e tests for the implementation

In this commit, e2e tests for the implementation are added.

Signed-off-by: Hayato Kiwata <haytok@amazon.co.jp>

Author: haytok

e2e/vm/config_darwin_test.go

@@ -22,7 +22,10 @@ import (
 	"github.com/runfinch/finch/pkg/config"
 )
 
-var finchConfigFilePath = os.Getenv("HOME") + "/.finch/finch.yaml"
+var (
+	finchConfigFilePath = os.Getenv("HOME") + "/.finch/finch.yaml"
+	finchConfigJSONPath = os.Getenv("HOME") + "/.finch/config.json"
+)
 
 func limaDataDirPath(installed bool) string {
 	limaConfigFilePath := defaultLimaDataDirPath

e2e/vm/config_windows_test.go

@@ -9,4 +9,7 @@ import (
 	"path/filepath"
 )
 
-var finchConfigFilePath = filepath.Join(os.Getenv("LOCALAPPDATA"), ".finch", "finch.yaml")
+var (
+	finchConfigFilePath = filepath.Join(os.Getenv("LOCALAPPDATA"), ".finch", "finch.yaml")
+	finchConfigJSONPath = filepath.Join(os.Getenv("LOCALAPPDATA"), ".finch", "config.json")
+)

e2e/vm/finch_config_file_test.go

@@ -20,8 +20,18 @@ import (
 
 // testFinchConfigFile makes sure that DOCKER_CONFIG is properly set to ~/.finch so that related information
 // is written to ~/.finch/config.json file.
-var testFinchConfigFile = func(o *option.Option) {
+var testFinchConfigFile = func(o *option.Option, installed bool) {
 	ginkgo.Describe("finch config file", func() {
+		var vmType string
+
+		ginkgo.BeforeEach(func() {
+			if runtime.GOOS == "windows" {
+				vmType = "wsl2"
+			} else {
+				vmType = "vz"
+			}
+		})
+
 		ginkgo.It("should store login credentials", func() {
 			filename := "htpasswd"
 			registryImage := "public.ecr.aws/docker/library/registry:2"
@@ -74,5 +84,14 @@ var testFinchConfigFile = func(o *option.Option) {
 			gomega.Expect(err).ShouldNot(gomega.HaveOccurred())
 			gomega.Expect(string(configContent)).ShouldNot(gomega.ContainSubstring(registry))
 		})
+
+		ginkgo.It("should refresh config.json if creds_helpers is not set in finch.yaml, but config.json is configured with credsStore", func() {
+			resetVM(o)
+			resetDisks(o, installed)
+			writeFile(finchConfigFilePath, []byte(fmt.Sprintf("cpus: 6\nmemory: 4GiB\nvmType: %s\nrosetta: true", vmType)))
+			writeFile(finchConfigJSONPath, []byte(`{"credsStore":"ecr-login"}`))
+			command.New(o, virtualMachineRootCmd, "init").WithoutCheckingExitCode().WithTimeoutInSeconds(160).Run()
+			gomega.Expect(string(readFile(finchConfigJSONPath))).Should(gomega.Equal(`{"auths":{}}`))
+		})
 	})
 }

e2e/vm/vm_darwin_test.go

@@ -64,7 +64,7 @@ func TestVM(t *testing.T) {
 		testVMLifecycle(o)
 		testAdditionalDisk(o, *e2e.Installed)
 		testConfig(o, *e2e.Installed)
-		testFinchConfigFile(o)
+		testFinchConfigFile(o, *e2e.Installed)
 		testVersion(o)
 		testNonDefaultOptions(o, *e2e.Installed)
 		testSupportBundle(o)

e2e/vm/vm_windows_test.go

@@ -44,7 +44,7 @@ func TestVM(t *testing.T) {
 	ginkgo.Describe("", func() {
 		testVMLifecycle(o)
 		testAdditionalDisk(o, *e2e.Installed)
-		testFinchConfigFile(o)
+		testFinchConfigFile(o, *e2e.Installed)
 		testVersion(o)
 		testSupportBundle(o)
 		testCredHelper(o, *e2e.Installed, *e2e.Registry)