Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform scale support? #29

Open
vorg opened this issue Aug 11, 2017 · 1 comment
Open

Transform scale support? #29

vorg opened this issue Aug 11, 2017 · 1 comment

Comments

@vorg
Copy link

vorg commented Aug 11, 2017

Keep in mind that scaling is a one-time transformation that only affects the current state of the shape. So calling scale() on an empty polygon, path or group will have no affect at all.

What is the motivation behind the current scale implementation? Following move vs translate shouldn't this be called e.g. resize ? While current scaling make is easier to draw as you go it makes the scene graph much less intuitive to use especially with groups and adding scaling after adding children.

@vorg vorg changed the title Support transform scale Transform scale support? Aug 11, 2017
@runemadsen
Copy link
Owner

runemadsen commented Aug 12, 2017

Thanks for your feedback. I think you're right that users might want both, and that the current scale() is probably better as resize(). I added it to my TODO, and keeping issue open until it's implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants