fix(app): Fix a regression related to URL fragments triggering navigation when not needed

Author: tadzik

e2e/cypress/integration/folder-switching.ts

@@ -33,4 +33,13 @@ describe('Switching between folders (and not-folders)', () => {
         // and back to inbox...
         goToInbox();
     });
+
+    it('can switch from an open email to another folder', () => {
+        localStorage.setItem('localSearchPromptDisplayed221', 'true');
+
+        cy.visit('/#Inbox:1');
+        cy.get('rmm-folderlist mat-tree-node:contains(Spam)').click();
+        cy.url().should('be', '/#Spam');
+        cy.get('rmm-folderlist mat-tree-node:contains(Spam)').should('have.class', 'selectedFolder');
+    });
 })

src/app/app.component.ts

@@ -887,7 +887,6 @@ export class AppComponent implements OnInit, AfterViewInit, DoCheck {
         return;
     }
 
-    console.log('Change selectedFolder');
     this.clearSelection();
 
     let doResetColumns = false;
@@ -1109,6 +1108,8 @@ export class AppComponent implements OnInit, AfterViewInit, DoCheck {
     if (fragment && this.singlemailviewer?.messageId) {
       fragment += `:${this.singlemailviewer.messageId}`;
     }
+    // needed so that our fragment listener doesn't trigger any further navigation
+    this.fragment = fragment;
     this.router.navigate(['/'], { fragment });
   }
 }