feat: OpenTofu support to helm chart #430
Conversation
There was a problem hiding this comment.
Hi @seifrajhi, thanks for the contribution! Please check the comments.
charts/atlantis/README.md
Outdated
| @@ -91,6 +91,7 @@ extraManifests: | |||
| | customPem | string | `""` | Allows to override the /etc/ssl/certs/ca-certificates.cer with your custom one. You have to create a secret with the specified name. | | |||
| | dataStorage | string | `""` | DEPRECATED - Disk space available to check out repositories. Example: 5Gi. | | |||
| | defaultTFVersion | string | `""` | Sets the default terraform version to be used in atlantis server. Check values.yaml for examples. | | |||
| | defaultTFVersion | string | `terraform` | Sets the default distribution to be used in atlantis server. Check values.yaml for examples. | | |||
There was a problem hiding this comment.
You probably meant:
| | defaultTFVersion | string | `terraform` | Sets the default distribution to be used in atlantis server. Check values.yaml for examples. | | |
| | defaultTFDistribution | string | `terraform` | Sets the default terraform distribution to use. Can be set to terraform or opentofu. | |
charts/atlantis/values.yaml
Outdated
| @@ -228,6 +228,9 @@ hideUnchangedPlanComments: false | |||
| defaultTFVersion: "" | |||
| # Example: "0.12.0". | |||
|
|
|||
| ### -- Sets which TF distribution to use. Can be set to terraform or opentofu. | |||
There was a problem hiding this comment.
And since it needs to match the readme file:
| ### -- Sets which TF distribution to use. Can be set to terraform or opentofu. | |
| ### -- Sets the default terraform distribution to use. Can be set to terraform or opentofu. |
charts/atlantis/values.yaml
Outdated
| @@ -240,6 +243,7 @@ disableRepoLocking: false | |||
| # -- Use Diff Markdown Format for color coding diffs. | |||
| enableDiffMarkdownFormat: false | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Typo? Please remove extra line.
|
@GMartinez-Sisti, It looks better now I think |
|
Hi @seifrajhi, something got merged, can you fix the conflict on the chart version pls? 🙏 |
charts/atlantis/values.schema.json
Outdated
| @@ -313,6 +313,10 @@ | |||
| "type": "string", | |||
| "description": "Default Terraform version to be used by atlantis server" | |||
| }, | |||
| "defaultTFDistribution": { | |||
| "type": "string", | |||
| "description": "Default Atlantis distribution to be used by atlantis server. Either Opentufu or terraform" | |||
There was a problem hiding this comment.
The default value is missing in the schema, and we can also add an enum.
| "description": "Default Atlantis distribution to be used by atlantis server. Either Opentufu or terraform" | |
| "description": "Default Atlantis distribution to be used by Atlantis server. Either terraform or opentofu", | |
| "default": "terraform", | |
| "enum": [ | |
| "terraform", | |
| "opentofu" | |
| ] |
There is a slight typo in opentofu as well
|
Hello @Sapr0 , thank you for the review, I just added that. |
|
@GMartinez-Sisti, I addressed the above comments |
|
@GMartinez-Sisti , I think the test is failing because the ordering of the properties is incorrect. To allow the test to pass, I moved the |
|
@seifrajhi to fix the CI please follow the recommendation steps:
And you also need to increase the chart version again please. |
I ran 
|
|
I have updated test to support the new env 🤞 
|
* feat: OpenTofu support to helm chart --------- Co-authored-by: Gabriel Martinez <19713226+GMartinez-Sisti@users.noreply.github.com> Signed-off-by: Ryan Dyer <ryan.dyer@favordelivery.com>
what
Upgrade Atlantis to the latest version
v0.30.0that adds support to Opentufureferences
closes #429