Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional toggle for specific prometheus metrics #4662

Open
1 task
igaskin opened this issue Jun 14, 2024 · 0 comments
Open
1 task

add optional toggle for specific prometheus metrics #4662

igaskin opened this issue Jun 14, 2024 · 0 comments
Labels
feature New functionality/enhancement metrics Stale

Comments

@igaskin
Copy link
Contributor

igaskin commented Jun 14, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

As an Atlantis admin, I would like to control which metrics are exposed on the /metrics prometheus endpoint.

Describe the solution you'd like

Have an option to the repo config to turn on specific metrics. This would reduce the size of the page in /metrics and also save on cost for downstream metrics storage.

example set of metrics to expose

                  "atlantis_project_plan_execution_time",
                  "atlantis_project_apply_execution_time",
                  "atlantis_project_plan_execution_success",
                  "atlantis_project_apply_execution_success",
                  "atlantis_project_plan_execution_success"

Describe the drawbacks of your solution

May limit discoverability of new metrics when added.

Describe alternatives you've considered

Filtering for specific metrics at the ingestion level.

@igaskin igaskin added the feature New functionality/enhancement label Jun 14, 2024
@igaskin igaskin changed the title add optional toggle for prometheus metrics add optional toggle for specific prometheus metrics Jun 14, 2024
@dosubot dosubot bot added the Stale label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement metrics Stale
Projects
None yet
Development

No branches or pull requests

2 participants