Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Requirement - Approved by CODEOWNERS? #1791

Closed
rayterrill opened this issue Sep 4, 2021 · 2 comments · Fixed by #2053
Closed

Apply Requirement - Approved by CODEOWNERS? #1791

rayterrill opened this issue Sep 4, 2021 · 2 comments · Fixed by #2053

Comments

@rayterrill
Copy link
Contributor

rayterrill commented Sep 4, 2021

Would it be possible to have another apply requirement - something like Approved by CODEOWNERS?

I realize that "mergeable" MOSTLY accomplishes this, because it requires CODEOWNERS approval prior to the PR being mergeable on Github. We also had set "atlantis apply" as a required status prior to making the PR mergeable - to prevent people from accidentally merging planned but not applied changes. Having mergeable and "atlantis apply" as a required status presents a Catch-22 - Atlantis won't let users apply because it's not mergeable yet, and Github won't let it go mergeable because there's no Atlantis apply.

It would be really nice if we could do both - block "atlantis apply" unless a CODEOWNER has approved, but NOT rely on mergeable as the status for this so we can also make "atlantis apply" a required status.

Cheers!

@nishkrishnan
Copy link
Contributor

Yeah we have some custom logic in our fork to ignore atlantis/apply when determining mergeability which basically solves this problem. I can see if we can at least get this upstream since I'm sure this would help a lot of folks.

@chenrui333
Copy link
Member

Got released under 0.19.0 today. Thanks @AndreZiviani for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants