Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ChatMessage serialization with janky openai types #16410

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

logan-markewich
Copy link
Collaborator

Fixes #16405

Need to ensure pydantic v2 continues to serialize additional kwargs properly

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 7, 2024
@logan-markewich logan-markewich merged commit 62849af into main Oct 7, 2024
11 checks passed
@logan-markewich logan-markewich deleted the logan/fix_serialization branch October 7, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError when saving message to ChatStore if return_direct=True was used in QueryEngineTool
1 participant