Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields to the returned nodes from DatabricksVectorSearch #15947

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Jasonli1997
Copy link

@Jasonli1997 Jasonli1997 commented Sep 10, 2024

Description

The returned nodes from the DatabricksVectorSearch currently do not include star_char, end_char, and relationships, the last of which is required for the usage of more advanced retrieval strategies such as Auto Merging Retriever, showcased in the demo notebook. After the changes I made, the three fields above will be added to the TextNode, if the user wishes to do so by including node_info column when initializing the DatabricksVectorSearch object.

Type of Change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I showed how the new feature works in the demo notebook.

  • Added new notebook (that tests end-to-end)

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 10, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant