This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Add Zulip Reader #181
Merged
Add Zulip Reader #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sweet! thanks so much |
sure! @jerryjliu let me know if anything needs to be fixed before we can merge :) |
jerryjliu
reviewed
Apr 12, 2023
loader_hub/zulip/base.py
Outdated
| from typing import List, Optional | ||
| from datetime import datetime | ||
| import os | ||
| import zulip |
There was a problem hiding this comment.
could this be a lazy import within the __init__.py file? see other data loaders as an example
mostly because it's breaking tests atm
There was a problem hiding this comment.
@blue-note bumping this! would be good to get this fixed, then we can land
There was a problem hiding this comment.
moved the import!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.