Changes to assign readonly properties

Author: cristiano-pacheco

src/Controller/Adminhtml/Index/Index.php

@@ -15,7 +15,7 @@ class Index extends Action
 
     public function __construct(
         Context $context,
-        private PageFactory $resultPageFactory
+        private readonly PageFactory $resultPageFactory
     ) {
         parent::__construct($context);
     }

src/Controller/Adminhtml/Message/Download.php

@@ -19,9 +19,9 @@ class Download extends Action
 
     public function __construct(
         Context $context,
-        private QueueErrorMessageRepository $messageRepository,
-        private RawFactory $rawFactory,
-        private QueueErrorMessageToRawResponseMapper $messageToRawResponseMapper
+        private readonly QueueErrorMessageRepository $messageRepository,
+        private readonly RawFactory $rawFactory,
+        private readonly QueueErrorMessageToRawResponseMapper $messageToRawResponseMapper
     ) {
         parent::__construct($context);
     }

src/Controller/Adminhtml/Message/MassDelete.php

@@ -20,10 +20,10 @@ class MassDelete extends Action
 
     public function __construct(
         Context $context,
-        private QueueErrorMessageRepository $messageRepository,
-        private RedirectFactory $redirectFactory,
-        private QueueErrorMessageCollectionFactory $collectionFactory,
-        private Filter $filter
+        private readonly QueueErrorMessageRepository $messageRepository,
+        private readonly RedirectFactory $redirectFactory,
+        private readonly QueueErrorMessageCollectionFactory $collectionFactory,
+        private readonly Filter $filter
     ) {
         parent::__construct($context);
     }

src/Controller/Adminhtml/Message/MassRequeue.php

@@ -20,10 +20,10 @@ class MassRequeue extends Action
 
     public function __construct(
         Context $context,
-        private PublishMessageToQueueService $publishMessageToQueueService,
-        private RedirectFactory $redirectFactory,
-        private QueueErrorMessageCollectionFactory $collectionFactory,
-        private Filter $filter
+        private readonly PublishMessageToQueueService $publishMessageToQueueService,
+        private readonly RedirectFactory $redirectFactory,
+        private readonly QueueErrorMessageCollectionFactory $collectionFactory,
+        private readonly Filter $filter
     ) {
         parent::__construct($context);
     }

src/Controller/Adminhtml/Message/Requeue.php

@@ -16,8 +16,8 @@ class Requeue extends Action
 
     public function __construct(
         Context $context,
-        private PublishMessageToQueueService $publishMessageToQueueService,
-        private RedirectFactory $redirectFactory
+        private readonly PublishMessageToQueueService $publishMessageToQueueService,
+        private readonly RedirectFactory $redirectFactory
     ) {
         parent::__construct($context);
     }

src/Mapper/QueueErrorMessageToRawResponseMapper.php

@@ -12,7 +12,7 @@
 class QueueErrorMessageToRawResponseMapper
 {
     public function __construct(
-        private MessageBodyDownloadFileNameBuilder $messageBodyDownloadFileNameBuilder
+        private readonly MessageBodyDownloadFileNameBuilder $messageBodyDownloadFileNameBuilder
     ) {
     }
 

src/Plugin/HandleQueueMessageRejectPlugin.php

@@ -14,8 +14,8 @@
 class HandleQueueMessageRejectPlugin
 {
     public function __construct(
-        private IsMessageShouldBeSavedForRetryService $isMessageShouldBeSavedForRetryService,
-        private SaveFailedMessageService $saveFailedMessageService
+        private readonly IsMessageShouldBeSavedForRetryService $isMessageShouldBeSavedForRetryService,
+        private readonly SaveFailedMessageService $saveFailedMessageService
     ) {
     }
 

src/Queue/Publisher.php

@@ -14,9 +14,9 @@
 class Publisher
 {
     public function __construct(
-        private ExchangeRepository $exchangeRepository,
-        private EnvelopeFactory $envelopeFactory,
-        private PublisherConfig $publisherConfig
+        private readonly ExchangeRepository $exchangeRepository,
+        private readonly EnvelopeFactory $envelopeFactory,
+        private readonly PublisherConfig $publisherConfig
     ) {
     }
 

src/Repository/Command/CreateMessageCommand.php

@@ -10,7 +10,7 @@
 
 class CreateMessageCommand
 {
-    public function __construct(private ResourceModel $resourceModel)
+    public function __construct(private readonly ResourceModel $resourceModel)
     {
     }
 

src/Repository/Command/DeleteMessageByIdCommand.php

@@ -11,8 +11,8 @@
 class DeleteMessageByIdCommand
 {
     public function __construct(
-        private ResourceModel $resourceModel,
-        private FindMessageByIdQuery $findMessageByIdQuery
+        private readonly ResourceModel $resourceModel,
+        private readonly FindMessageByIdQuery $findMessageByIdQuery
     ) {
     }
 

src/Repository/Command/DeleteMessageCommand.php

@@ -10,7 +10,7 @@
 
 class DeleteMessageCommand
 {
-    public function __construct(private ResourceModel $resourceModel)
+    public function __construct(private readonly ResourceModel $resourceModel)
     {
     }
 

src/Repository/Query/FindMessageByIdQuery.php

@@ -12,8 +12,8 @@
 class FindMessageByIdQuery
 {
     public function __construct(
-        private ResourceModel $resourceModel,
-        private ModelFactory $modelFactory
+        private readonly ResourceModel $resourceModel,
+        private readonly ModelFactory $modelFactory
     ) {
     }
 

src/Repository/Query/FindQueueRetryLimitByTopicNameQuery.php

@@ -9,7 +9,7 @@
 
 class FindQueueRetryLimitByTopicNameQuery
 {
-    public function __construct(private DataInterface $configStorage)
+    public function __construct(private readonly DataInterface $configStorage)
     {
     }
 

src/Repository/QueueErrorMessageRepository.php

@@ -16,10 +16,10 @@
 class QueueErrorMessageRepository
 {
     public function __construct(
-        private CreateMessageCommand $createMessageCommand,
-        private DeleteMessageCommand $deleteMessageCommand,
-        private DeleteMessageByIdCommand $deleteMessageByIdCommand,
-        private FindMessageByIdQuery $findMessageByIdQuery
+        private readonly CreateMessageCommand $createMessageCommand,
+        private readonly DeleteMessageCommand $deleteMessageCommand,
+        private readonly DeleteMessageByIdCommand $deleteMessageByIdCommand,
+        private readonly FindMessageByIdQuery $findMessageByIdQuery
     ) {
     }
 

src/SchemaLocator/QueueRetrySchemaLocator.php

@@ -10,7 +10,7 @@
 
 class QueueRetrySchemaLocator implements SchemaLocatorInterface
 {
-    public function __construct(private UrnResolver $urnResolver)
+    public function __construct(private readonly UrnResolver $urnResolver)
     {
     }
 

src/Service/IsMessageShouldBeSavedForRetryService.php

@@ -11,9 +11,9 @@
 class IsMessageShouldBeSavedForRetryService
 {
     public function __construct(
-        private MessageQueueRetryConfig $messageQueueRetryConfig,
-        private GetMessageRetriesCountService $getMessageRetriesCountService,
-        private FindQueueRetryLimitByTopicNameQuery $findQueueRetryLimitByTopicNameQuery
+        private readonly MessageQueueRetryConfig $messageQueueRetryConfig,
+        private readonly GetMessageRetriesCountService $getMessageRetriesCountService,
+        private readonly FindQueueRetryLimitByTopicNameQuery $findQueueRetryLimitByTopicNameQuery
     ) {
     }
 

src/Service/PublishMessageToQueueService.php

@@ -15,8 +15,8 @@
 class PublishMessageToQueueService
 {
     public function __construct(
-        private Publisher $publisher,
-        private QueueErrorMessageRepository $messageRepository
+        private readonly Publisher $publisher,
+        private readonly QueueErrorMessageRepository $messageRepository
     ) {
     }
 

src/Service/SaveFailedMessageService.php

@@ -12,9 +12,9 @@
 class SaveFailedMessageService
 {
     public function __construct(
-        private QueueErrorMessageFactory $messageFactory,
-        private QueueErrorMessageRepository $messageRepository,
-        private GetMessageRetriesCountService $getMessageRetriesCountService
+        private readonly QueueErrorMessageFactory $messageFactory,
+        private readonly QueueErrorMessageRepository $messageRepository,
+        private readonly GetMessageRetriesCountService $getMessageRetriesCountService
     ) {
     }
 

src/System/Config/MessageQueueRetryConfig.php

@@ -10,7 +10,7 @@ class MessageQueueRetryConfig
 {
     private const XML_PATH_ENABLE_DELAY_QUEUE = 'message_queue_retry/general/enable_delay_queue';
 
-    public function __construct(private ScopeConfigInterface $scopeConfig)
+    public function __construct(private readonly ScopeConfigInterface $scopeConfig)
     {
     }