Skip to content

Conversation

@zecakeh
Copy link
Contributor

@zecakeh zecakeh commented Oct 10, 2025

According to MSC4326 / Spec PR

Let's do it now since it requires a breaking change.

@github-actions
Copy link

github-actions bot commented Oct 10, 2025

The following breaking changes were detected.
Please make sure these are intentional and listed in the respective changelogs.

ruma-common

--- failure trait_method_missing: pub trait method removed or renamed ---

Description:
A trait method is no longer callable, and may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.44.0/src/lints/trait_method_missing.ron

Failed in:
method try_into_http_request_with_user_id of trait OutgoingRequestAppserviceExt, previously in file /home/runner/work/ruma/ruma/target/semver-checks/git-origin_main/472a269f064e4ecf21ed05a213215eb16d0538f3/crates/ruma-common/src/api.rs:315

@zecakeh zecakeh force-pushed the zecakeh/appservice-device-id branch from b969484 to 772653b Compare October 20, 2025 07:30
@zecakeh zecakeh requested a review from Kladki October 20, 2025 16:49
@zecakeh zecakeh force-pushed the zecakeh/appservice-device-id branch from 772653b to a33fb47 Compare October 20, 2025 19:46
@zecakeh zecakeh enabled auto-merge (rebase) October 20, 2025 19:47
@zecakeh zecakeh merged commit 87f421c into main Oct 20, 2025
25 checks passed
@zecakeh zecakeh deleted the zecakeh/appservice-device-id branch October 20, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants