web: Add custom profiles to separate the build cache for the two wasm modules #6043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torokati44
force-pushed
the
wasm-profiles
branch
from
82251c3 to
f097995
Compare
Herschel
approved these changes
Jan 13, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of an improvement over #5834.
This avoids always nuking the build cache (twice) when running
npm run build:dual-wasm.While
wasm-optis still doing the work twice, that is a lot faster and less "harmful" - not cache-polluting.A somewhat related note: I think
\\\"$CARGO_FEATURES\\\"causes the--featuresargument to be passed as literally$CARGO_FEATUREStocargo. Does it then substitute the envvar internally?EDIT: FWIW setting
CARGO_FEATURES=whateverfornpm run ...does work, at least on Linux, so I guess it's okay.