fix(filters): Add debug mode for all errors handlers

rucken · Jan 17, 2018 · efc0c53 · efc0c53
1 parent afe4933
commit efc0c53
Showing 1 changed file with 18 additions and 6 deletions.
diff --git a/src/libs/core/exceptions/custom-exception.filter.ts b/src/libs/core/exceptions/custom-exception.filter.ts
@@ -6,9 +6,13 @@ import { CustomValidationError } from './custom-validation.error';
 
 @Catch(SyntaxError, CustomValidationError, JsonWebTokenError, Error)
 export class CustomExceptionFilter implements ExceptionFilter {
-    catch(exception: CustomValidationError | JsonWebTokenError, response) {
+    catch(exception: CustomValidationError | JsonWebTokenError | SyntaxError | Error, response) {
         const errors = {};
         if (exception instanceof CustomValidationError) {
+            if (process.env.DEBUG === 'true' || process.env.DEBUG === '1') {
+                response.status(HttpStatus.BAD_REQUEST).json(exception);
+                return;
+            }
             exception.errors.forEach((error: ValidationError) => {
                 Object.keys(error.constraints).forEach(
                     (key: string) => {
@@ -23,16 +27,24 @@ export class CustomExceptionFilter implements ExceptionFilter {
             return;
         }
         if (exception instanceof JsonWebTokenError) {
+            if (process.env.DEBUG === 'true' || process.env.DEBUG === '1') {
+                response.status(HttpStatus.BAD_REQUEST).json(exception);
+                return;
+            }
             response.status(HttpStatus.BAD_REQUEST).json({
-                nonFieldErrors: [exception.message]
+                message: exception.message
             });
             return;
         }
-        if (process.env.DEBUG === 'true' || process.env.DEBUG === '1') {
-            console.error(exception);
-            response.status(HttpStatus.BAD_REQUEST).json({ message: String(exception) });
+        if (exception instanceof SyntaxError || exception instanceof Error) {
+            if (process.env.DEBUG === 'true' || process.env.DEBUG === '1') {
+                response.status(HttpStatus.BAD_REQUEST).json(exception);
+                return;
+            }
+            response.status(HttpStatus.BAD_REQUEST).json({
+                message: exception.message ? exception.message : String(exception)
+            });
             return;
         }
-        response.status(HttpStatus.BAD_REQUEST).json(exception);
     }
 }