Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on fixed ids in contributions_spec #673

Merged
merged 1 commit into from
Sep 5, 2020
Merged

Don't rely on fixed ids in contributions_spec #673

merged 1 commit into from
Sep 5, 2020

Conversation

solebared
Copy link
Collaborator

Ran into a case where the id conflicted with an existing record in the test db (possibly from a seed).

@solebared
Don't rely on fixed ids in contributions_spec
46387a6 
Ran into a case where the id conflicted with an existing record in the
test db (possibly from a seed).
@solebared solebared requested a review from h-m-m September 4, 2020 17:30
h-m-m
h-m-m approved these changes Sep 5, 2020
View reviewed changes
Copy link
Collaborator

@h-m-m h-m-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, Lasitha. @viamin had this exact same problem.

@solebared solebared merged commit e736cf9 into main Sep 5, 2020
@solebared solebared deleted the drop-reliance-on-id-in-contributions-spec branch September 5, 2020 16:42
@viamin
Copy link
Contributor

viamin commented Sep 5, 2020

I did find that running the setup code exactly like circleci did seem to avoid the spec failure.

@solebared
Copy link
Collaborator Author

I did find that running the setup code exactly like circleci did seem to avoid the spec failure.

Good to know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-m-m h-m-m h-m-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solebared @viamin @h-m-m