Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent Back and Cancel Button text #1120

Open
bmorrall opened this issue Sep 20, 2024 · 0 comments · May be fixed by #1121
Open

Inconsistent Back and Cancel Button text #1120

bmorrall opened this issue Sep 20, 2024 · 0 comments · May be fixed by #1121

Comments

@bmorrall
Copy link

I've noticed some of the Back buttons have different CaPiTalIZaTiOn which is a little (very minorly) inconsistent.

Some of these links/buttons have the Back/Cancel text in a span, some does not, although visually they are both the same.

All of these links have a "<<" prepended to them; some of these are provided as strings will be escaped as html safe &lt;, the values provided directly in erb files are not html escaped and can trip up parsers and code quality tools (if they were to be added).

All of these are the most minor of minor issues, but I had a lazy afternoon to fix them and needed a Github Issue to link to.

@bmorrall bmorrall linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant