Open
Conversation
Member
|
This looks pretty cool, thank you! It looks that hanami 2.0.0.alpha1 is already using newer dry-validation, so this could work. Could you please also add an example app to the tests, so we can test it against this newer hanami? You can have a look at how this has been done with rails using appraisal. |
Author
|
I'll do! |
Author
|
|
Member
|
Sure thing. We could also add this to the earlier version of config gem (I think we added dry-validation in 2.1), but not sure if it's worth it. Better wait I guess... Thanks for following up! |
Member
|
Issues
======
- Added 15
See the complete overview on Codacy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add hanami support. 🌸
This code works well in
1.7.0of rubyconfig/config.But this is not usable in
2.2.1. Becausedry-validationversion is difference in gemspecI don't know what to do for this problem.
I hope this PR helps you!. 😄