move Service Ticket generation to module method

Signed-off-by: Tyler Pickett <t.pickett66@gmail.com>

Author: tpickett66

lib/rubycas-server-core/tickets.rb

@@ -40,7 +40,7 @@ def self.generate_ticket_granting_ticket(username, client, extra_attributes = {}
           end
         end
 
-        def generate_service_ticket(service, username, tgt, client)
+        def self.generate_service_ticket(service, username, tgt, client)
           st = ServiceTicket.new
           st.ticket = "ST-" + Util.random_string
           st.service = service

spec/rubycas-server-core/tickets_spec.rb

@@ -4,6 +4,7 @@ module RubyCAS::Server::Core
   describe RubyCAS::Server::Core::Tickets do
     let(:client_hostname) { 'myhost.test' }
     let(:username) { 'myuser' }
+    let(:service) { 'https://myservice.test' }
 
     before do
       RubyCAS::Server::Core.setup("spec/config/config.yml")
@@ -62,35 +63,29 @@ module RubyCAS::Server::Core
       end
     end
 
-    describe "#generate_service_ticket(service, username, tgt)" do
-      before do
-        @username = 'testuser'
-        @client_hostname = "myhost.test"
-        @service = 'myservice.test'
-        @tgt = @cas.generate_ticket_granting_ticket(@username, @client_hostname)
-        @st = @cas.generate_service_ticket(@service, @username, @tgt, @client_hostname)
-      end
+    describe ".generate_service_ticket(service, username, tgt)" do
+      let(:tgt) { Tickets.generate_ticket_granting_ticket(username, client_hostname) }
+      let(:st) { Tickets.generate_service_ticket(service, username, tgt, client_hostname) }
 
       it "should return a ServiceTicket" do
-        @st.class.should == Tickets::ServiceTicket
+        st.class.should == Tickets::ServiceTicket
       end
 
       it "should not include the service identifer in the ticket string" do
-        @st.ticket.should_not match /#{@service}/
+        st.ticket.should_not match /#{service}/
       end
 
       it "should not mark the ST as consumed" do
-        @st.consumed.should be_nil
+        st.consumed.should be_nil
       end
 
       it "must generate a ticket that starts with 'ST-'" do
-        @st.ticket.should match /^ST-/
+        st.ticket.should match /^ST-/
       end
 
       it "should assoicate the ST with the supplied TGT" do
-        @st.ticket_granting_ticket.id.should == @tgt.id
+        st.ticket_granting_ticket.id.should == tgt.id
       end
-
     end
 
     describe "#generate_proxy_ticket(target_service, pgt)" do