Skip to content

Translate "Support of Ruby 2.3 has ended" (ja) #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2019
Merged

Translate "Support of Ruby 2.3 has ended" (ja) #2070

merged 4 commits into from
May 23, 2019

Conversation

acomagu
Copy link
Contributor

@acomagu acomagu commented May 23, 2019

No description provided.

@acomagu acomagu requested a review from a team as a code owner May 23, 2019 03:53
@JuanitoFatas JuanitoFatas requested a review from takahashim May 23, 2019 03:57
toru-takahashi
toru-takahashi reviewed May 23, 2019
View reviewed changes
@takahashim
Copy link
Contributor

Thanks for your PR!

Ruby 2.6 や 2.5 へのアップグレードを強く推奨します。

Could you add a phraseas soon as possible in the original (e.g. 速やかに ?)

@acomagu
Copy link
Contributor Author

acomagu commented May 23, 2019

@takahashim Thank you for reviewing!! 🙏
Fixed: a055a51

takahashim
takahashim approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@takahashim takahashim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 💯

@JuanitoFatas JuanitoFatas merged commit dd79aa2 into ruby:master May 23, 2019
@JuanitoFatas
Copy link
Member

皆様あいがとうございました! Thanks all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toru-takahashi toru-takahashi toru-takahashi left review comments

@takahashim takahashim takahashim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acomagu @takahashim @JuanitoFatas @toru-takahashi