Allow shutdown_pipe to be passed in via @config#44
Merged
jeremyevans merged 2 commits intoruby:masterfrom Jul 21, 2020
Merged
Conversation
Contributor
|
I think it's fine to expose this, but we should add a test for it to prevent regressions. |
Contributor
Author
|
Test added - thanks for your time Jeremy! |
Contributor
|
Thanks for working on this! |
Contributor
|
@wishdev Looks like there is a nondeterministic failure in the test: https://github.com/ruby/webrick/runs/894956154 Can you please add a pull request to fix that? Otherwise, I'll probably have to revert. |
Member
Contributor
on high load-average environments. http://ci.rvm.jp/logfiles/brlog.trunk-no-theap.20200924-222101 |
Contributor
Author
I'm going to discuss this on #54 because that's where the test code in question lives. |
Merged
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Nov 13, 2020
Because the test for this change was still broken.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to be able to fork a webrick server and then shut it down from the parent process.
The @shutdown_pipe variable within webrick/server is the perfect tool for the job but it is not settable/accessible outside of the class. This patch simply allows for a pipe to be passed in via the server config.