Skip to content

Question: Migration from RFC2396 make_regexp to RFC3986 #151

Open
@svoop

Description

I'm doing a bit of warn-housekeeping on Hanami which uses the following (without passing a schema) to match URIs in the asset handling:

ABSOLUTE_URL_MATCHER = URI::DEFAULT_PARSER.make_regexp

This triggers the obsolescence warning since the DEFAULT_PARSER has switched to RFC3986_PARSER which just delegates make_regexp back to the RFC2396_PARSER.

Is there a recommended path forward?

  1. URI::DEFAULT_PARSER.make_regexp --replace-with--> URI::RFC2396_PARSER.make_regexp
  2. URI::DEFAULT_PARSER.make_regexp --replace-with--> URI::RFC3986_Parser::RFC3986_URI

The warning suggest 1, but RFC2396 is obsolete, so rather 2? Or is there a third way? Thanks a lot for any hints!

(Update: Capybara uses the same URI::DEFAULT_PARSER.make_regexp as well, so the same question arises there.)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions