Fix some flaky test failures on Windows #7440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some specs assert empty output, but sometimes they print warnings about redefinition warnings. Ignore those until they are fixed upstream.
deivid-rodriguez
force-pushed
the
troubleshoot_windows_ci
branch
from
fdd7b63 to
0cd3b6d
Compare
Contributor
Author
|
Merging to try make CI a bit more stable, but happy to iterate or use a different approach if I get feedback after merge! |
4 tasks
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 5, 2024
Fix some flaky test failures on Windows (cherry picked from commit e2904f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Some specs assert empty output, but sometimes they print warnings about redefinition warnings.
What is your fix for the problem, implemented in this PR?
Ignore those until they are fixed upstream.
Make sure the following tasks are checked