Fix & Deprecate REXML::Text#text_indent

lib/rexml/child.rb

@@ -88,7 +88,7 @@ def document
 
     # This doesn't yet handle encodings
     def bytes
-      document.encoding
+      document&.encoding
 
       to_s
     end

lib/rexml/text.rb

@@ -269,14 +269,15 @@ def wrap(string, width, addnewline=false)
     end
 
     def indent_text(string, level=1, style="\t", indentfirstline=true)
+      Kernel.warn("#{self.class.name}#indent_text is deprecated.  See REXML::Formatters", uplevel: 1)
       return string if level < 0
       new_string = ''
       string.each_line { |line|
         indent_string = style * level
         new_line = (indent_string + line).sub(/[\s]+$/,'')
-        new_string << new_line
+        new_string += new_line
       }
-      new_string.strip! unless indentfirstline
+      new_string = new_string.strip unless indentfirstline
       new_string
     end
 

test/test_text.rb

@@ -69,5 +69,10 @@ def test_clone
       assert_equal(text.to_s,
                    text.clone.to_s)
     end
+
+    def test_indent_text
+      text = Text.new("")
+      assert_equal("\tline1\tline2\tline3", text.indent_text("line1\r\nline2\r\nline3\r\n"))
+    end
   end
 end