Use StringScanner#peek_byte to get double or single quotation mark#227
Merged
Conversation
kou
reviewed
Dec 20, 2024
## Why?
`StringScanner#peek_byte` is fast, because it does not generate String object.
## Benchmark
```
RUBYLIB= BUNDLER_ORIG_RUBYLIB= /Users/naitoh/.rbenv/versions/3.3.4/bin/ruby -v -S benchmark-driver /Users/naitoh/ghq/github.com/naitoh/rexml/benchmark/parse.yaml
ruby 3.3.4 (2024-07-09 revision be1089c8ec) [arm64-darwin22]
Calculating -------------------------------------
before after before(YJIT) after(YJIT)
dom 19.753 19.888 35.641 35.928 i/s - 100.000 times in 5.062402s 5.028121s 2.805792s 2.783339s
sax 30.349 30.978 53.485 57.885 i/s - 100.000 times in 3.295012s 3.228103s 1.869671s 1.727567s
pull 34.170 35.436 61.713 66.534 i/s - 100.000 times in 2.926534s 2.821955s 1.620404s 1.502996s
stream 33.121 35.268 60.751 63.276 i/s - 100.000 times in 3.019222s 2.835443s 1.646065s 1.580374s
Comparison:
dom
after(YJIT): 35.9 i/s
before(YJIT): 35.6 i/s - 1.01x slower
after: 19.9 i/s - 1.81x slower
before: 19.8 i/s - 1.82x slower
sax
after(YJIT): 57.9 i/s
before(YJIT): 53.5 i/s - 1.08x slower
after: 31.0 i/s - 1.87x slower
before: 30.3 i/s - 1.91x slower
pull
after(YJIT): 66.5 i/s
before(YJIT): 61.7 i/s - 1.08x slower
after: 35.4 i/s - 1.88x slower
before: 34.2 i/s - 1.95x slower
stream
after(YJIT): 63.3 i/s
before(YJIT): 60.8 i/s - 1.04x slower
after: 35.3 i/s - 1.79x slower
before: 33.1 i/s - 1.91x slower
```
- YJIT=ON : 1.01x - 1.08x faster
- YJIT=OFF : 1.00x - 1.06x faster
Co-authored-by: Sutou Kouhei <kou@clear-code.com>
3d66b77 to
4956690
Compare
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
StringScanner#peek_byteis fast, because it does not generate String object.Benchmark