Fix rendering bug of nomultiline prompt#730
Merged
tompng merged 1 commit intoruby:masterfrom Jul 12, 2024
Merged
Conversation
tompng
force-pushed
the
print_nomultiline_prompt_bugfix
branch
from
b89be82 to
e146ccc
Compare
Fix bug of `print('a'*10); Reline.readline('>')` wrong rendering
tompng
force-pushed
the
print_nomultiline_prompt_bugfix
branch
from
e146ccc to
8c157ed
Compare
st0012
approved these changes
Jul 11, 2024
Member
st0012
left a comment
st0012
left a comment
There was a problem hiding this comment.
Can confirm it fixed the weird behaviour, and at the same time makes the code a lot simpler ❤️
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jul 12, 2024
(ruby/reline#730) Fix bug of `print('a'*10); Reline.readline('>')` wrong rendering ruby/reline@c0469a12b9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug of
print('a'*10); Reline.readline('>')wrong renderingReadline prints prompt before any other escape sequence, which is ensured in readline-ext test. Reline follows this in singleline mode.
Just after printing prompt, Reline sets
@rendered_screen.lines = [[[0, prompt_width, prompt]]]representing that prompt is rendered in column 0.But in this case
foobar>is rendered in terminal screen.bar>is not rendered in column 0.