Unite key bindings, key mapping and multibyte buffer#708
Closed
tompng wants to merge 1 commit into
Closed
Conversation
This was referenced May 27, 2024
Member
Author
|
Closing this because this refactoring series (split into 4 pull requests and merged) is completed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
KeyActor, key_bindings(key_stroke.rb) and multibyte_buffer(LineEditor) can be united. This will reduce complexity.
This pull request is a goal of this refactor. I'm planning to open several separate pull requests.
What can be solved?
What to do
:matching | :matched | :matching_matched) but the last one is missing now