Set EastAsianWidth::UNICODE_VERSION#586
Merged
ima1zumi merged 3 commits intoruby:masterfrom Aug 29, 2023
elfham:eaw-version
Merged
Set EastAsianWidth::UNICODE_VERSION#586ima1zumi merged 3 commits intoruby:masterfrom elfham:eaw-version
ima1zumi merged 3 commits intoruby:masterfrom
elfham:eaw-version
Conversation
ima1zumi
reviewed
Aug 29, 2023
| class Reline::Unicode::EastAsianWidth | ||
| # This is based on EastAsianWidth.txt | ||
| # EastAsianWidth.txt | ||
| UNICODE_VERSION = '15.0.0' |
Member
There was a problem hiding this comment.
Since this constant is not used in Reline, why not leave it as a comment?
Contributor
Author
There was a problem hiding this comment.
OK, I fixed the code that way.
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Aug 29, 2023
(ruby/reline#586) * Set EastAsianWidth::UNICODE_VERSION * Commented out UNICODE_VERSION in Reline::Unicode::EastAsianWidth * Commented out UNICODE_VERSION in Reline::Unicode::EastAsianWidth ruby/reline@6d94f2a26a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #438
The beginning of the comment in
EastAsianWidth.txtcontains the Unicode version.At least since Unicode 3.2.0, the version seems to be included.
So, the version is retrieved from there.
The version is set to
Reline::Unicode::EastAsianWidth::UNICODE_VERSION.The variable name
UNICODE_VERSIONis taken fromRbConfig::CONFIG["UNICODE_VERSION"].If the comment format is changed in the future and the Unicode version fails to be retrieved, a warning will be displayed and set
UNICODE_VERSION = nil.