Readline vi-mode doesn't work as expected

[m-chrzan]

Problem overview

The new irb version appears to have problems with vi-mode readline (don't know about emacs-mode).

Not sure what the full extent of these problems is, but noticed a few common normal mode commands not working as expected. These include:

• A does not jump to the end of the line
• similarly, I does not jump to the beginning of the line
• t enters insert mode instead of waiting for a character and then jumping before its first occurence after the cursor. Similarly with T and F (f appears to work correctly)
• u doesn't undo the last edit
• c is a no-op instead of waiting for a movement, then changing text between cursor and movement destination

I imagine this problem is more widespread and there are other readline functionalities that don't function as expected. All of these work as expected in irb --legacy and other readline programs (e.g. bash).

Steps to reproduce

(this is all on irb-1.2.1 installed from GitHub)

To reproduce the first issue from above, set readline to vi-mode, e.g. by modifying ~/.inputrc:

set editing-mode vi

Start irb, then enter the following sequence of keystrokes:

123<escape>BA

This results in the buffer containing the following (^ indicates cursor position):

A123
 ^

in normal mode, whereas irb --legacy (or another readline program like bash) would lead to

123
   ^

in insert mode.

[aycabta]

Thank you for your reporting!

Memo:

• A and I are implemented by e4fc1ee
• t, T, and F what are motions...are implemented by Implement vi_to_next_char #111 and Implement vi_prev_char and vi_to_prev_char #112
• c what is a kind of operator with other motion...is implemented by Implement vi_change_meta #114
• u was being filed at Implement undo of vi mode #8

[ilikepi]

Here are some other things missing, tested in irb 1.4.1:

• ; and , are no-ops; should repeat the previous find action (f or F + a character)
• ~ is a no-op; it should change the case of the letter under the cursor
• s is a no-op; it should yank the character under the cursor and enter insert mode
• S is a no-op; it should yank the entire line and enter insert mode
• C is a no-op; it should yank text from the cursor to the end of the line and enter insert mode
• R is a no-op; it should enter replacement mode