Introduce apply_default_exclude config to separate default and user excluding patterns
#1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Dec 23, 2024
lib/rdoc/options.rb
Outdated
| @@ -355,18 +355,24 @@ class RDoc::Options | |||
| # +--[no-]embed-mixins+ (Default is +false+.) | |||
| attr_accessor :embed_mixins | |||
|
|
|||
| ## | |||
| # Exclude default pattersn to exclude. | |||
| attr_reader :default_exclude | |||
There was a problem hiding this comment.
Since the set of excluded patterns is called @exclude now, @default_exclude feels like would contain the value of DEFAULT_EXCLUDE. I think maybe apply_default_exclude expresses what this value does better?
nobu
force-pushed
the
default_exclude
branch
from
8cc1011 to
e10554b
Compare
st0012
changed the title
--exclude option from defaultsapply_default_exclude config to separate default and user excluding patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ruby/ruby#12386.