Skip to content

Commit 7a6015a

Browse files
committed
Rename to nesting_namespaces
1 parent 71ee189 commit 7a6015a

File tree

3 files changed

+19
-19
lines changed

3 files changed

+19
-19
lines changed

lib/rdoc/code_object/class_module.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -298,19 +298,19 @@ def full_name
298298
##
299299
# Return array of full_name splitted by +::+.
300300

301-
def namespaces
301+
def nesting_namespaces
302302
@namespaces ||= full_name.split("::").reject(&:empty?)
303303
end
304304

305305
##
306-
# Return array of fully qualified namespaces.
306+
# Return array of fully qualified nesting namespaces.
307307
#
308308
# For example, if full_name is +A::B::C+, this method returns <code>["A", "A::B", "A::B::C"]</code>
309309

310-
def fully_qualified_namespaces
311-
return namespaces if namespaces.length < 2
312-
@fqns ||= namespaces.map.with_index do |_, i|
313-
namespaces[0..i].join("::")
310+
def fully_qualified_nesting_namespaces
311+
return nesting_namespaces if nesting_namespaces.length < 2
312+
@fqns ||= nesting_namespaces.map.with_index do |_, i|
313+
nesting_namespaces[0..i].join("::")
314314
end
315315
end
316316

lib/rdoc/generator/darkfish.rb

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ def generate_class klass, template_file = nil
350350
asset_rel_prefix = rel_prefix + @asset_rel_path
351351
svninfo = get_svninfo(current)
352352

353-
breadcrumb = generate_namespaces_breadcrumb(current, rel_prefix)
353+
breadcrumb = generate_nesting_namespaces_breadcrumb(current, rel_prefix)
354354

355355
@title = "#{klass.type} #{klass.full_name} - #{@options.title}"
356356

@@ -830,18 +830,18 @@ def generate_ancestor_list(ancestors, klass)
830830

831831
private
832832

833-
def namespaces_to_class_modules klass
833+
def nesting_namespaces_to_class_modules klass
834834
tree = {}
835835

836-
klass.namespaces.zip(klass.fully_qualified_namespaces) do |ns, fqns|
836+
klass.nesting_namespaces.zip(klass.fully_qualified_nesting_namespaces) do |ns, fqns|
837837
tree[ns] = @store.classes_hash[fqns] || @store.modules_hash[fqns]
838838
end
839839

840840
tree
841841
end
842842

843-
def generate_namespaces_breadcrumb klass, rel_prefix
844-
namespaces_to_class_modules(klass).map do |namespace, class_module|
843+
def generate_nesting_namespaces_breadcrumb klass, rel_prefix
844+
nesting_namespaces_to_class_modules(klass).map do |namespace, class_module|
845845
path = class_module ? (rel_prefix + class_module.path).to_s : ""
846846
{ name: namespace, path: path, self: klass.full_name == class_module&.full_name }
847847
end

test/rdoc/test_rdoc_class_module.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1506,26 +1506,26 @@ def test_update_extends_with_colons
15061506
assert_equal [a, c], @c1.extends
15071507
end
15081508

1509-
def test_namespaces
1509+
def test_nesting_namespaces
15101510
cm1 = RDoc::ClassModule.new "A"
1511-
assert_equal ["A"], cm1.namespaces
1511+
assert_equal ["A"], cm1.nesting_namespaces
15121512

15131513
cm2 = RDoc::ClassModule.new "A::B"
1514-
assert_equal ["A", "B"], cm2.namespaces
1514+
assert_equal ["A", "B"], cm2.nesting_namespaces
15151515

15161516
cm3 = RDoc::ClassModule.new "::A::B::C"
1517-
assert_equal ["A", "B", "C"], cm3.namespaces
1517+
assert_equal ["A", "B", "C"], cm3.nesting_namespaces
15181518
end
15191519

1520-
def test_fully_qualified_namespaces
1520+
def test_fully_qualified_nesting_namespaces
15211521
cm1 = RDoc::ClassModule.new "A"
1522-
assert_equal ["A"], cm1.fully_qualified_namespaces
1522+
assert_equal ["A"], cm1.fully_qualified_nesting_namespaces
15231523

15241524
cm2 = RDoc::ClassModule.new "A::B"
1525-
assert_equal ["A", "A::B"], cm2.fully_qualified_namespaces
1525+
assert_equal ["A", "A::B"], cm2.fully_qualified_nesting_namespaces
15261526

15271527
cm3 = RDoc::ClassModule.new "::A::B::C"
1528-
assert_equal ["A", "A::B", "A::B::C"], cm3.fully_qualified_namespaces
1528+
assert_equal ["A", "A::B", "A::B::C"], cm3.fully_qualified_nesting_namespaces
15291529
end
15301530

15311531
class TestRDocClassModuleMixins < XrefTestCase

0 commit comments

Comments
 (0)