ssl: add SSLContext#sigalgs= and #client_sigalgs= #895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The CI failures are not related to this PR. I opened the issue ticket #897. The ruby/ruby removed |
junaruga
added a commit
to junaruga/ruby-openssl-pqc-test
that referenced
this pull request
Jun 5, 2025
Note the following PR is needed to use the feature. ruby/openssl#895
junaruga
added a commit
to junaruga/ruby-openssl-pqc-test
that referenced
this pull request
Jun 5, 2025
Note the following PR is needed to use the feature. ruby/openssl#895
5 tasks
junaruga
reviewed
Jun 17, 2025
Member
junaruga
left a comment
junaruga
left a comment
There was a problem hiding this comment.
I reviewed. Could you check my comments? Thank you!
rhenium
force-pushed
the
ky/ssl-sigalgs
branch
2 times, most recently
from
68c9b8f to
d54774e
Compare
junaruga
reviewed
Jun 20, 2025
Add methods for setting supported signature algorithms, corresponding to SSL_CTX_set1_sigalgs_list() and SSL_CTX_set1_client_sigalgs_list(), respectively. Co-authored-by: Markus Jung <markus.jung@vivavis.com>
Member
|
Now the PR looks good to me! Thank you for working on it! |
Member
Author
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods for setting supported signature algorithms, corresponding to
SSL_CTX_set1_sigalgs_list()andSSL_CTX_set1_client_sigalgs_list(), respectively.Supersedes #769
/cc @mj-vivavis